feat(java-base): Add jvmkill utility - #1579
Merged
Merged
Conversation
Member
Why is that? What can that operator do that ours can't? |
Member
Author
|
Does #1578 (comment) clarify it? There is no other operator involved, only "our" trino-operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #1578.
This PR only adds a
/stackable/libjvmkill.sofile to the existing java-base image, so it's guaranteed to be non-breaking.This should already enable customers to use it (see SUP-354).
After the 26.7 release we will actually start to use the file in trino-operator by setting
-agentpath:/stackable/libjvmkill.soI did a quick sanity check to make sure we can at least load the agent (I did not test if it improves the JVM situation):
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.